Diffa Diffa → 0.9.3

Comments and changes to this ticket

• 

  Ben Hood February 9th, 2011 @ 09:22 PM

  (from [abc327f24df85616e8736398cf5c1119f87cc00c]) [#178] Serialisation support for Diffa configuration. https://github.com/lshift/diffa/commit/abc327f24df85616e8736398cf5c...

• 

  Ben Hood February 9th, 2011 @ 09:36 PM

  (from [8163e3f2b3a0bfb235fd7234014d9974ef73d42b]) [#178] Wire in persistence of configuration. https://github.com/lshift/diffa/commit/8163e3f2b3a0bfb235fd7234014d...

• 

  Ben Hood February 10th, 2011 @ 09:55 AM

  (from [4154c02a70c5d3208db0bccc3b6a27e724c51fd4]) [#178] Support apply configuration changes as incrementally as possible. Reinforce testing. https://github.com/lshift/diffa/commit/4154c02a70c5d3208db0bccc3b6a...

• 

  Ben Hood February 10th, 2011 @ 10:35 AM

  (from [cfecbb6e857a9cb52ea07d14740f485410e69216]) [#178] Add integration test for configuration upload. https://github.com/lshift/diffa/commit/cfecbb6e857a9cb52ea07d14740f...

• 

  Paul Jones February 10th, 2011 @ 10:42 AM

  • State changed from “open” to “resolved”
  • Assigned user changed from “Paul Jones” to “Ben Hood”

  Implemented, and ready for review.

• 

  Paul Jones February 10th, 2011 @ 10:42 AM

  Implemented, and ready for review.

• 

  Ben Hood February 10th, 2011 @ 10:42 AM

  (from [c0a5a9eeafdc459bb6a211650c42f78d1b4bc8df]) [#178] Remove println. https://github.com/lshift/diffa/commit/c0a5a9eeafdc459bb6a211650c42...

• 

  Ben Hood February 10th, 2011 @ 12:48 PM

  • State changed from “resolved” to “open”
  • Assigned user changed from “Ben Hood” to “Paul Jones”

  QA notes:

  • Is the field email supposed to get bound to the property value in DiffaProperty?

  <class name="net.lshift.diffa.agent.rest.DiffaProperty">
      <field name="key" type="string">
        <bind-xml name="key" node="attribute" />
      </field>
      <field name="value" type="string">
        <bind-xml name="email" node="text" />
      </field>
  </class>
  

  • Configuration:

    • There appears to be some repetition in the applyConfiguration function:

      filter(a => diffaConfig.X.find(y => y.name == x.name).isEmpty)
      

    • What happens when something fails inside this code block? What state is the DB in?

  • {ActivePairManager,EndpointLifecycleListener}: Introducing these to make mocking easier is fine, but trait behaviors should be well documented.

  • Documentation: We definitely need an example somewhere with some kind of explanation, potentially inline as comments
  • ConfigurationResource.applyConfiguration: What XML does the POST create when it returns?
  • {DiffaConfigReaderWriterTest,ConfigurationUploadTest}: Can the expected XML be written as parsed
  • ConfigurationUploadTest is missing a license header
  • Serializability - you might need to run me through the need for this - I couldn't quite make out why the original types could not be extended, but there's probably a reason.
  • Serializable - the default language of Diffa is US English
  • Potentially we can use this mechanism in the to be revamped integration tests - I'll create a link in #168
  • Also, is there any value in having the agent search its classpath for the existence of a diffa-config.xml and then applying that on boot-up?
• 

  Ben Hood February 10th, 2011 @ 01:50 PM

  (from [88602eb8896380cb9f6f9eaea76f635222f5d949]) [#178] First round QA updates. https://github.com/lshift/diffa/commit/88602eb8896380cb9f6f9eaea76f...

• 

  Ben Hood February 10th, 2011 @ 01:57 PM

  (from [64fdcdceaea4888a51bf13c2ab66339c62e39927]) [#178] Add missing import https://github.com/lshift/diffa/commit/64fdcdceaea4888a51bf13c2ab66...

• 

  Ben Hood February 10th, 2011 @ 02:32 PM

  (from [863eec23d6cc3b5c45008c63d00b40002b20a99a]) [#178] Second round QA updates. https://github.com/lshift/diffa/commit/863eec23d6cc3b5c45008c63d00b...

• 

  Ben Hood February 10th, 2011 @ 02:32 PM

  (from [a53a0be3b3c92c0088d22a9b52fa6acc4496fee0]) [#178] XML doesn't need to be a string. https://github.com/lshift/diffa/commit/a53a0be3b3c92c0088d22a9b52fa...

• 

  Paul Jones February 10th, 2011 @ 03:04 PM

  • State changed from “open” to “resolved”
  • Assigned user changed from “Paul Jones” to “Ben Hood”

  QA remarks implemented.

• 

  Ben Hood February 10th, 2011 @ 03:30 PM

  (from [1128d4cb0c0c41fa314713579312f3936205b74d]) Merged [#178] into master https://github.com/lshift/diffa/commit/1128d4cb0c0c41fa314713579312...

• 

  Ben Hood February 10th, 2011 @ 03:30 PM

  • State changed from “resolved” to “closed”

  See #179 and #168 for related follow up work.