#100 ✓closed
Jonathan Lister

Load content into content viewer white box

Reported by Jonathan Lister | 2010-10-07 11:21:30 UTC | in 0.8

This is a call to the server for each item. Do this when blob or row clicked.

Comments and changes to this ticket

  • Jonathan Lister

    Jonathan Lister 2010-10-08 11:02:11 UTC

    • State changed from “new” to “open”
    • Assigned user changed from “Jonathan Lister” to “Ben Hood”
    • Milestone order changed from “35” to “0”

    If the URL of the participants is on another domain (or port), the participants will need to support JSONP for getting the content.

    I have the interface doing what it can to get the content, but it can't access cross-domain stuff.

  • Ben Hood

    Ben Hood 2010-10-08 11:11:42 UTC

    • no changes were found...
  • Ben Hood

    Ben Hood 2010-10-08 11:14:49 UTC

    Sorry, I don't understand this: ATM the agent is proxying the call to the participants so I don't see the x-domain implication. BTW this is already working (i.e. the diagnostic box is correctly populated with the content that the demo participant set) for me, so I am a bit confused.

  • Ben Hood

    Ben Hood 2010-10-08 18:30:15 UTC

    • Assigned user changed from “Ben Hood” to “Jonathan Lister”

    Jonathan, I'm assigning this back to you to denote the fact that next question is for you :-)

  • Jonathan Lister

    Jonathan Lister 2010-10-08 19:09:27 UTC

    • Assigned user changed from “Jonathan Lister” to “Ben Hood”

    I might be getting the URL for the content-getting from the wrong place, but I think it is from /config/pairs/${id}.

    In this picture, you see the upstream and downstream 'url' parameters pointing to hosts that are on a different port to the agent: http://img.skitch.com/20101008-bja4h8j16at83fpg4xce6bppfg.jpg

    You said it was working for you, so I'm a bit unsure how your browser is doing the x-domain thing.

  • Ben Hood

    Ben Hood 2010-10-08 22:55:44 UTC

    • Assigned user changed from “Ben Hood” to “Jonathan Lister”

    The call to get the content detail is this one:

    http://diffa.lshift.net/doc/rest/diffs/get/events/p_sessionId/p_evt...

    The UI does a GET on the agent, who, in turn, proxies the actual request out to the individual participants. This is completely transparent to the client, so there is no x-domain issue. Please get in contact with me tomorrow to clarify this because I can see us misunderstanding each via Lighthouse.

  • Jonathan Lister

    Jonathan Lister 2010-10-09 14:59:49 UTC

    I see! I was using the wrong URL... thanks.

  • Jonathan Lister

    Jonathan Lister 2010-10-09 15:28:05 UTC

    • Assigned user changed from “Jonathan Lister” to “Ben Hood”

    I have noticed that the response from the server is only "Expanded Detail" - this should send something for each of the upstream and downstream participants. How about:

    {"upstream":"Expanded Detail for upstream","downstream":"Expanded Detail for downstream"}
    
  • Ben Hood

    Ben Hood 2010-10-09 15:29:06 UTC

    (from [e09b4bbdc1426bf59ee2ca3119b5ce1ae4a35d24]) Getting content from server rather than trying cross-domain requests to participants

    [[#100]] http://github.com/lshift/diffa/commit/e09b4bbdc1426bf59ee2ca3119b5c...

  • Ben Hood

    Ben Hood 2010-10-11 11:02:25 UTC

    • State changed from “open” to “closed”

    Yes, you're right - ATM the server is only returning a hard coded string "Expanded detail" (see ticket #6 for background). So the call you are currently making is correct, hence this issue can be closed. For note, please see ticket #127 which is related to this issue.

  • Ben Hood

    Ben Hood 2010-10-11 14:34:01 UTC

    Jonathan - I've plumbed through a little of #6 so that the upstream is being set correctly (i.e. dynamically), but the UI seems to be sending the same for the downstream as well - note that I haven't looked into this in detail yet. Do you have any ideas off the top of your head?

  • Jonathan Lister

    Jonathan Lister 2010-10-11 15:39:46 UTC

    As you've pointed out, the interface needs to discriminate between the two participants. I'll make the future notes on #6.

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป

A Real Time Differencing Tool.

Shared Ticket Bins

People watching this ticket

Referenced by

Pages