Migration does not work with Oracle
Reported by Ben Hood | September 5th, 2011 @ 10:31 AM | in 0.9-series (closed)
The DB migration does not work with Oracle because the Oracle dialect does not support identity columns:
Caused by: org.hibernate.MappingException: Dialect does not support identity key generation
at org.hibernate.dialect.Dialect.getIdentityColumnString(Dialect.java:506) ~[hibernate-core-3.6.0.Final.jar:3.6.0.Final]
at org.hibernate.dialect.Dialect.getIdentityColumnString(Dialect.java:496) ~[hibernate-core-3.6.0.Final.jar:3.6.0.Final]
at net.lshift.hibernate.migrations.SQLStringHelpers.generateIdentityColumnString(SQLStringHelpers.java:40) ~[hibernate-migrations-0.1-SNAPSHOT.jar:na]
at net.lshift.hibernate.migrations.CreateTableBuilder.toSql(CreateTableBuilder.java:96) ~[hibernate-migrations-0.1-SNAPSHOT.jar:na]
at net.lshift.hibernate.migrations.CreateTableBuilder.prepare(CreateTableBuilder.java:87) ~[hibernate-migrations-0.1-SNAPSHOT.jar:na]
at net.lshift.hibernate.migrations.SingleStatementMigrationElement.apply(SingleStatementMigrationElement.java:28) ~[hibernate-migrations-0.1-SNAPSHOT.jar:na]
at net.lshift.hibernate.migrations.MigrationBuilder.apply(MigrationBuilder.java:82) ~[hibernate-migrations-0.1-SNAPSHOT.jar:na]
at net.lshift.diffa.kernel.config.AddPersistentDiffsMigrationStep$.migrate(HibernateConfigStorePreparationStep.scala:399) ~[diffa-kernel-0.9-SNAPSHOT.jar:na]
Comments and changes to this ticket
-
Ben Hood September 5th, 2011 @ 03:06 PM
(from [fa11f89732b0238d5b72f23197ad745bbf67c643]) [#357] Added sequence based PK generation for dialects that don't support identity columns https://github.com/lshift/diffa/commit/fa11f89732b0238d5b72f23197ad...
-
Ben Hood September 5th, 2011 @ 05:51 PM
(from [0332ffd583c0be876e39c1b430dd79bb7b864cc8]) [#357] Added better diagnostics for schema export https://github.com/lshift/diffa/commit/0332ffd583c0be876e39c1b430dd...
-
-
Ben Hood September 5th, 2011 @ 07:59 PM
- State changed from “new” to “resolved”
- Assigned user set to “Paul Jones”
Implemented a differentiation between dialects that support identity columns and those that don't. Also refactored the error handling a bit to make problems like a bit easier to diagnose, although this is still quite unsatisfactory - see https://hibernate.onjira.com/browse/HHH-6633
PR raised -> resolving
-
Ben Hood September 5th, 2011 @ 08:10 PM
I have tested this by booting the agent against an Oracle 11g instance.
-
Ben Hood September 5th, 2011 @ 08:13 PM
(from [fb354c1ec9b108ec6d5c1c6cbe9314e672350ff0]) [#357] Bumped the version of Hibernate https://github.com/lshift/diffa/commit/fb354c1ec9b108ec6d5c1c6cbe93...
-
Paul Jones September 5th, 2011 @ 11:13 PM
- State changed from “resolved” to “open”
- Assigned user changed from “Paul Jones” to “Ben Hood”
A few minor requests on the Pull Request, but apart from these the patch looks ok.
=> Re-opening for minor fixes.
-
Ben Hood September 5th, 2011 @ 11:29 PM
(from [104afb11474a09bbc8db1f2e00a200193ed005b9]) [#357] QA remark to give tests a better name https://github.com/lshift/diffa/commit/104afb11474a09bbc8db1f2e00a2...
-
-
Ben Hood September 6th, 2011 @ 12:02 AM
- State changed from “open” to “resolved”
- Assigned user changed from “Ben Hood” to “Paul Jones”
Addressed QA remarks, re-resolving.
-
Ben Hood September 6th, 2011 @ 12:52 AM
(from [d6524f0decb0f1da5cd4564aab789693e8f10f30]) [#357] Further cleanup logging and preparing. https://github.com/lshift/diffa/commit/d6524f0decb0f1da5cd4564aab78...
-
-
Ben Hood September 6th, 2011 @ 09:41 AM
- State changed from “resolved” to “closed”
This has been merged into master, hence closing
-
Ben Hood November 14th, 2011 @ 05:35 PM
- Milestone set to “0.9-series”
- Milestone order changed from “122” to “0”
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.
Create new ticket
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป
A Real Time Differencing Tool.
Ben Hood