Tests are timezone sensitive
Reported by Ben Hood | March 10th, 2011 @ 11:42 PM
When you run the build in a non-GMT timezone, some tests fail:
Failed tests:
deletingSource(net.lshift.diffa.kernel.differencing.LuceneVersionCorrelationStoreTest)
deletingDest(net.lshift.diffa.kernel.differencing.LuceneVersionCorrelationStoreTest)
queryUpstreamRangeReturnsInIDOrder(net.lshift.diffa.kernel.differencing.LuceneVersionCorrelationStoreTest)
queryDownstreamRangeReturnsInIDOrder(net.lshift.diffa.kernel.differencing.LuceneVersionCorrelationStoreTest)
schematize(net.lshift.diffa.kernel.config.EndpointTest)
This appears to be due to differences in date comparisons, see the attached Surefire reports.
Furthermore, as part of #204, some questionable date handling w.r.t. time zones appears to have crept into the code base. My suggestion is to centralize all date parsing and make sure that time zones are handled consistently.
Comments and changes to this ticket
-
-
Ben Hood May 11th, 2011 @ 08:56 AM
- Milestone cleared.
- Milestone order changed from “4” to “0”
-
Paul Jones August 23rd, 2011 @ 12:47 AM
- State changed from “new” to “open”
- Assigned user set to “Paul Jones”
-
Ben Hood August 23rd, 2011 @ 01:05 AM
(from [ccb32d2d5c3541caedc6461c9e9b1cb256e1c8ef]) [#197] Fix support for running tests in non-UTC timezones. https://github.com/lshift/diffa/commit/ccb32d2d5c3541caedc6461c9e9b...
-
Paul Jones August 23rd, 2011 @ 06:44 AM
- State changed from “open” to “resolved”
- Assigned user changed from “Paul Jones” to “Ben Hood”
Ready for QA - Patch extracted from the #340 branch.
I've created a TeamCity build for this as well to verify that the changes work cleanly on a machine in UTC as well.
-
Ben Hood August 23rd, 2011 @ 06:37 PM
(from [bf2b446b401b62a398172b8eb94976c76b29effc]) Merge pull request #65 from lshift/197
[#197] Fix support for running tests in non-UTC timezones. https://github.com/lshift/diffa/commit/bf2b446b401b62a398172b8eb949...
-
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.
Create new ticket
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป
A Real Time Differencing Tool.
Ben Hood