EventFormatMapper should be able to output a sequence of WireEvents
Reported by John Wright | February 4th, 2011 @ 04:41 PM | in 0.9.3
Currently, the EventFormatMapper maps from a raw input string to a WireEvent. The input string may actually represent a collection of objects to be mapped to WireEvents, so the return type of the map function should be changed to Seq[WireEvent].
Comments and changes to this ticket
-
John Wright February 4th, 2011 @ 06:09 PM
- State changed from “open” to “resolved”
- Assigned user changed from “John Wright” to “Ben Hood”
Done, also snuck in some WireEvent-related changes ("upstream", "downstream-same" and "downstream-correlated" are now compile-time constants)
-
Ben Hood February 5th, 2011 @ 09:29 AM
- State changed from “resolved” to “open”
- Assigned user changed from “Ben Hood” to “John Wright”
The EventFormatMapper changes are fine.
Turning the WireEvent-related changes into compile time constants is also good, however, from a dependency perspective, I don't think core type definitions should depend on Wire* objects - I think the dependency should be the other way around -> reopening.
-
John Wright February 7th, 2011 @ 10:48 AM
- State changed from “open” to “resolved”
- Assigned user changed from “John Wright” to “Ben Hood”
Change event types are now case objects, fixing the dependency issue. I'd tried this approach before and backed it out because it seemed a bit ornate, but on balance it's better.
-
-
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.
Create new ticket
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป
A Real Time Differencing Tool.
People watching this ticket
Ben Hood
Referenced by
-
171
EventFormatMapper should be able to output a sequence of WireEvents
(from [3757fb9e31b6e3dafed9430233bd2ba8caa8de5d])
Merged ...