Differentiate between Date and DateTime constraints
Reported by Ben Hood | 2011-04-18 09:56:33 UTC
The current differentiation between yyyy-MM-dd and yyyy-MM-ddThh:mm:ss.msZ is too vague. Hence the current Date constraint should only accept yyyy-MM-dd and we should introduce a new DateTime constraint. The semantics should be:
-
Date - yyyy-MM-dd:
- The lower bound means the start of the day at 0 o'clock i.e. yyyy-MM-ddT00:00:00.000Z, inclusive
- The upper bound means plus one day minus 1 millisecond i.e. yyyy-MM-ddT23:59:59.999Z, inclusive
-
DateTime - yyyy-MM-ddThh:mm:ss.msZ:
- The time bounds with this granularity include each bound, i.e. it is a fully open time range
Comments and changes to this ticket
-
Paul Jones 2011-04-18 09:58:49 UTC
I think a clarification here would be that dates should be passed as just dates wherever possible - the extension in a datetime should be reserved for cases where the expansion is absolutely necessary.
Similarly, the datetime should be configurable using just dates, with the bounds detailed on the date (ie, lower is midnight, upper is the very end of the day).
-
Ben Hood 2011-04-18 16:45:38 UTC
- State changed from “new” to “open”
- Assigned user set to “Ben Hood”
-
-
Ben Hood 2011-04-18 19:45:10 UTC
(from [e84960aae14dba2d0cb6467b3ec7facc97b0da37]) [#204]: Centralized the type information https://github.com/lshift/diffa/commit/e84960aae14dba2d0cb6467b3ec7...
-
Ben Hood 2011-04-19 08:04:27 UTC
(from [8ceed359821c5c8088c5729d8d95f9383fcdf808]) [#204] Renamed Dates constants https://github.com/lshift/diffa/commit/8ceed359821c5c8088c5729d8d95...
-
Ben Hood 2011-04-19 08:36:48 UTC
(from [8bf0ff858b9a5dbee31457513a7717bc7fefdeff]) [#204] Deleted unused function https://github.com/lshift/diffa/commit/8bf0ff858b9a5dbee31457513a77...
-
Ben Hood 2011-04-19 10:52:55 UTC
(from [0b54e05357022f6efc0e59a3a4c7f3443a710122]) [#204] Fixed a bug whereby local dates defined as date time types were not being widened https://github.com/lshift/diffa/commit/0b54e05357022f6efc0e59a3a4c7...
-
Ben Hood 2011-04-19 10:58:30 UTC
(from [27a0f5465e7a6e3ed8f12582e2ee7e44dc5e31e3]) [#204] Addresses QA remark about the name of the type registry https://github.com/lshift/diffa/commit/27a0f5465e7a6e3ed8f12582e2ee...
-
Ben Hood 2011-04-19 12:48:44 UTC
- State changed from “open” to “resolved”
- Assigned user changed from “Ben Hood” to “Paul Jones”
-
Paul Jones 2011-04-19 17:26:48 UTC
Generally looks ok to me. I've added a few more notes for documentation fixes, and I'm probably just going to need to read the updated AbstractDataDrivenPolicyTest in detail.
-
Ben Hood 2011-04-19 19:25:55 UTC
(from [10d8838bbcc4b7cc04423116e47ad3b4ad274a78]) [#204] Adjusted comment according to QA remark https://github.com/lshift/diffa/commit/10d8838bbcc4b7cc04423116e47a...
-
Ben Hood 2011-04-19 19:27:40 UTC
(from [decc102cee8995285412cc2c6f28af41a6a94d5d]) [#204] Adjusted comment according to QA remark https://github.com/lshift/diffa/commit/decc102cee8995285412cc2c6f28...
-
Ben Hood 2011-04-19 19:37:43 UTC
(from [ade2a01f792b7b3f237f97113007fe3774216623]) [#204] Just to make sure we don't do anything bad around accidentally rounding the date, change this case to be some arbitrary in-day time instead of midnight https://github.com/lshift/diffa/commit/ade2a01f792b7b3f237f97113007...
-
-
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.
Create new ticket
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป
A Real Time Differencing Tool.
People watching this ticket
Ben Hood
Referenced by
-
205
Consider prefixing data type names
Ticket #204 introduced the notion of a TypeDescriptor
whi...
-
204
Differentiate between Date and DateTime constraints
(from [d347696a9ed36fba472d1395f112d3fb0a5907ab])
[#204] ...
-
204
Differentiate between Date and DateTime constraints
(from [e84960aae14dba2d0cb6467b3ec7facc97b0da37])
[#204]:...
-
204
Differentiate between Date and DateTime constraints
(from [8ceed359821c5c8088c5729d8d95f9383fcdf808])
[#204] ...
-
204
Differentiate between Date and DateTime constraints
(from [8bf0ff858b9a5dbee31457513a7717bc7fefdeff])
[#204] ...
-
204
Differentiate between Date and DateTime constraints
(from [0b54e05357022f6efc0e59a3a4c7f3443a710122])
[#204] ...
-
204
Differentiate between Date and DateTime constraints
(from [27a0f5465e7a6e3ed8f12582e2ee7e44dc5e31e3])
[#204] ...
-
204
Differentiate between Date and DateTime constraints
(from [10d8838bbcc4b7cc04423116e47ad3b4ad274a78])
[#204] ...
-
204
Differentiate between Date and DateTime constraints
(from [decc102cee8995285412cc2c6f28af41a6a94d5d])
[#204] ...
-
204
Differentiate between Date and DateTime constraints
(from [ade2a01f792b7b3f237f97113007fe3774216623])
[#204] ...
-
200
Attribute type should be appropriately formatted
This problem has been addressed as part of #204, hence
cl...
-
204
Differentiate between Date and DateTime constraints
(from [e94dfa0edb69b56f8a91e2e4727a40254d565d7b])
Merge [...
-
197
Tests are timezone sensitive
Furthermore, as part of #204, some questionable date hand...