Change VersionCorrelationStore to be per-pair
Reported by John Wright | February 28th, 2011 @ 11:46 AM | in 0.9.3
Currently the VersionCorrelationStore is global. In order to simplify access and allow for more concurrency, there should be one store per pair key.
Comments and changes to this ticket
-
John Wright February 28th, 2011 @ 05:02 PM
- State changed from “open” to “resolved”
- Assigned user changed from “John Wright” to “Paul Jones”
-
John Wright February 28th, 2011 @ 05:09 PM
- State changed from “resolved” to “open”
- Assigned user changed from “Paul Jones” to “John Wright”
Forgot to ensure that the close() method is called on the version correlation store when a pair is deleted - reopening
-
John Wright March 1st, 2011 @ 12:04 PM
- State changed from “open” to “resolved”
- Assigned user changed from “John Wright” to “Paul Jones”
Added lifecycle handling, and opened #194.
https://github.com/johnwright/diffa/commit/16711c196b3f3ab725933c13...
-
Paul Jones March 1st, 2011 @ 12:14 PM
- State changed from “resolved” to “open”
- Assigned user changed from “Paul Jones” to “John Wright”
QA Notes:
All looks good. Only thing missing is a test case for the Factory itself to verify that it is indeed using separate stores (eg, an isolation test of some kind).
-
John Wright March 1st, 2011 @ 02:21 PM
- State changed from “open” to “resolved”
- Assigned user changed from “John Wright” to “Paul Jones”
Added an isolation test:
https://github.com/johnwright/diffa/commit/467473dbf49e4e387425a0cb...
-
John Wright March 1st, 2011 @ 02:26 PM
Also added a guard on the remove() method of the version correlation store:
https://github.com/johnwright/diffa/commit/0cd87cda4f408e2d6d577ce7...
-
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.
Create new ticket
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป
A Real Time Differencing Tool.
Paul Jones