Diffa Diffa → 0.9.3

Comments and changes to this ticket

• 

  Ben Hood February 11th, 2011 @ 08:44 AM

  • Title changed from “.NET Participants” to “.NET Participant”
• 

  Ben Hood February 11th, 2011 @ 09:36 AM

  • State changed from “resolved” to “open”
  • Assigned user changed from “Ben Hood” to “Ben James”

  QA notes:

  On the whole this a good first cut, but there a few things that need some attention:

  • This should run on TC
  • This doesn't compile because WebGAC is not set up correctly - put this in your *.csproj:

  <Import Project="$(MSBuildExtensionsPath)\WebGAC\WebGAC.targets" />
  

  • IQueryConstraint:

    • A constraint contains the category it has to constrain, not the data type - the type is inferred from ref data
    • If in doubt, you can make the constraint definitions symmetrical to the Scala definitions - see #185
    • You're missing Prefix constraints, but this can be added as a separate ticket because it's not on the critical path (see #181)
    • Address the TODO comments

  • Testing:

    • The category functions/bucketing tests should be data driven to give better coverage, but this can be a follow on ticket (see #183)
    • DigestBuilderIntegerBucketingTest:{33,59} - the lastUpdated field is no longer used
    • Create a follow up ticket for the Assert.AreEqual TODOs

  • EntityVersion:

    • L54:ToString("o")?

  • Each class and each publicly visible method or property should be documented appropriately (especially key interface definitions such as IParticipant)

  • ParticipantHandler: What does this comment mean:

    // TODO un-fudge this DeserializeObject(JContainer.ToString()) nonsense
    

  • What happened to the Mock test that we were discussing the replay/verify cycle over?

• 

  Ben Hood February 11th, 2011 @ 10:02 AM

  • Milestone set to “0.9.3”

• You flagged this item as spam.
  

  Ben James February 11th, 2011 @ 12:59 PM

  • State changed from “open” to “resolved”

  • It's now building on LShift's TeamCity and publishing Net.LShift.Diffa.Messaging.AMQP.dll and Net.LShift.Diffa.Participants.dll as artifacts
  • IQueryConstraint: renamed DataType to Category and addressed TODOs.
  • Removed lastUpdated variables
  • Created #184 for the Assert.AreEqual TODOs
  • Commented to explain the meaning of the "o" format string
  • Added more docs
  • The TODO on ParticipantHandler is because I'm not sure I'm using the Newtonsoft API most efficiently. But it does pass the unit tests. I can investigate this when there is time and create a follow-up ticket if it turns out there's a better way
• 

  Ben Hood February 11th, 2011 @ 06:13 PM

  • State changed from “resolved” to “closed”

  QA+